Control.flushQueueOnDnd: simplify commit#2573
Merged
akurtakov merged 1 commit intoDec 9, 2025
Merged
Conversation
Contributor
Test Results 115 files + 4 115 suites +4 12m 20s ⏱️ - 5m 21s Results for commit 0f1f762. ± Comparison against base commit 63d5582. This pull request removes 37 and adds 56 tests. Note that renamed tests count towards both.This pull request removes 2 skipped tests and adds 3 skipped tests. Note that renamed tests count towards both.This pull request skips 2 tests.♻️ This comment has been updated with latest results. |
akurtakov
reviewed
Oct 2, 2025
tmssngr
force-pushed
the
Control.flushQueueOnDnd-simplification
branch
2 times, most recently
from
abe2183 to
ccae0e8
Compare
tmssngr
force-pushed
the
Control.flushQueueOnDnd-simplification
branch
2 times, most recently
from
6bc5e5d to
0f1f762
Compare
sendOrPost set event.data to null before sending, so keep that behavior
akurtakov
force-pushed
the
Control.flushQueueOnDnd-simplification
branch
from
0f1f762 to
f55c497
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inlined
sendOrPostfor this special case making it more obvious that an (immediate)sendEventis happening.